Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97699439
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -303,10 +305,22 @@ public InternalScanner
preCompactScannerOpen(ObserverContext<RegionCoprocessorEn
// Get the latest tx snapshot state for the compaction
TransactionVisibilityState snapshot = cache.getLatestState();
- // Record tx state before the compaction
- if (compactionState != null) {
+ if (pruneEnable == null) {
+ Configuration conf = getConfiguration(c.getEnvironment());
+ pruneEnable =
conf.getBoolean(TxConstants.TransactionPruning.PRUNE_ENABLE,
--- End diff --
If the configuration is not available for the first time then won't this
become false for the whole run? Should we return null from `getConfiguration`
in case configuration is not available? This way we can skip the run
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
