[
https://issues.apache.org/jira/browse/TEPHRA-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116231#comment-16116231
]
ASF GitHub Bot commented on TEPHRA-236:
---------------------------------------
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r131594887
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -177,11 +173,23 @@ public void close() throws IOException {
} catch (IOException e) {
try {
secondaryIndexTable.close();
+ conn.close();
--- End diff --
`conn` may not be closed if `secondaryIndexTable.close()` throws an
exception.
Adding another nested try-catch will make the code complex. Instead what do
you think about putting each close in its own try-catch block, remember the
first exception, and add the other exceptions as suppressed to the first
exception?
> Replace deprecated HBase APIs HBaseAdmin and HTableDescriptor
> -------------------------------------------------------------
>
> Key: TEPHRA-236
> URL: https://issues.apache.org/jira/browse/TEPHRA-236
> Project: Tephra
> Issue Type: Improvement
> Reporter: Biju Nair
> Assignee: Poorna Chandra
> Priority: Minor
>
> {{HBaseAdmin}}, {{HTable}} and {{HTableDescriptor}} client APIs are
> deprecated/or marked for internal use in HBase 1.0 and planned for removal in
> HBase 2.0. Need to replace these classes with new ones provided in HBase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
