[ 
https://issues.apache.org/jira/browse/TEPHRA-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116230#comment-16116230
 ] 

ASF GitHub Bot commented on TEPHRA-236:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/45#discussion_r131594276
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
 ---
    @@ -177,11 +173,23 @@ public void close() throws IOException {
         } catch (IOException e) {
           try {
             secondaryIndexTable.close();
    +        conn.close();
           } catch (IOException ex) {
             e.addSuppressed(e);
           }
           throw e;
         }
         secondaryIndexTable.close();
    +    conn.close();
    +  }
    +
    +  protected void finalize() throws Throwable {
    --- End diff --
    
    We try not to rely on `finalize()` since there is no guarantee when it will 
be called. Also since we are closing the connection in the `close()` method, 
there is no need for finalize. Let's remove this method.


> Replace deprecated HBase APIs HBaseAdmin and HTableDescriptor
> -------------------------------------------------------------
>
>                 Key: TEPHRA-236
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-236
>             Project: Tephra
>          Issue Type: Improvement
>            Reporter: Biju Nair
>            Assignee: Poorna Chandra
>            Priority: Minor
>
> {{HBaseAdmin}}, {{HTable}} and {{HTableDescriptor}} client APIs are 
> deprecated/or marked for internal use in HBase 1.0 and planned for removal in 
> HBase 2.0. Need to replace these classes with new ones provided in HBase. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to