aicam commented on code in PR #3710:
URL: https://github.com/apache/texera/pull/3710#discussion_r2315792608


##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/hub/HubResource.scala:
##########
@@ -148,6 +149,12 @@ object HubResource {
     buffer.toList.asJava
   }
 
+  def toActionEnum(a: ActionType): ActionEnum = {

Review Comment:
   You can add this function to the exact `ActionType` object directly



##########
deployment/k8s/texera-helmchart/files/texera_ddl.sql:
##########
@@ -345,17 +348,19 @@ CREATE TABLE IF NOT EXISTS workflow_view_count
     FOREIGN KEY (wid) REFERENCES workflow(wid) ON DELETE CASCADE
     );
 
--- Drop old workflow_user_activity (if any), replace with user_activity
--- user_activity table
-CREATE TABLE IF NOT EXISTS user_activity
-(
-    uid           INTEGER NOT NULL DEFAULT 0,
-    id            INTEGER NOT NULL,
-    type          VARCHAR(15) NOT NULL,
-    ip            VARCHAR(15) DEFAULT NULL,
-    activate      VARCHAR(10) NOT NULL,
-    activity_time TIMESTAMP DEFAULT CURRENT_TIMESTAMP
-    );
+-- Drop old workflow_user_activity and user_activity (if any), replace with 
user_action
+-- user_action table
+CREATE TABLE IF NOT EXISTS user_action (
+    user_action_id BIGSERIAL PRIMARY KEY,
+    uid            INTEGER,
+    ip             VARCHAR(15),
+    "time"         TIMESTAMP DEFAULT CURRENT_TIMESTAMP,

Review Comment:
   If `time` is a reserved keyword, I recommend rename it, please discuss it in 
Slack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@texera.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to