aicam commented on code in PR #3710:
URL: https://github.com/apache/texera/pull/3710#discussion_r2319143938
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/hub/HubResource.scala:
##########
@@ -21,23 +21,8 @@ package edu.uci.ics.texera.web.resource.dashboard.hub
import edu.uci.ics.texera.dao.SqlServer
import edu.uci.ics.texera.dao.jooq.generated.Tables._
-import HubResource.{
- AccessResponse,
- CountResponse,
- LikedResponse,
- UserRequest,
- ViewRequest,
- fetchDashboardDatasetsByDids,
- fetchDashboardWorkflowsByWids,
- isLikedHelper,
- recordLikeActivity,
- recordUserActivity
-}
-import
edu.uci.ics.texera.web.resource.dashboard.user.workflow.WorkflowResource.{
- DashboardWorkflow,
- baseWorkflowSelect,
- mapWorkflowEntries
-}
+import HubResource.{AccessResponse, CountResponse, LikedResponse, UserRequest,
ViewRequest, fetchDashboardDatasetsByDids, fetchDashboardWorkflowsByWids,
isLikedHelper, recordLikeActivity, recordUserActivity}
Review Comment:
Ditto
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/hub/HubResource.scala:
##########
@@ -165,16 +151,17 @@ object HubResource {
action: ActionType
): Unit = {
val userIp = request.getRemoteAddr
Review Comment:
Since we are referring to `user_action` table, it is better to rename all
functions to `action` so please rename `recordUserActivity` to
`recordUserAction` and other places that `user activity` is referring to
updates in `user_action` table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
