Sentiaus commented on PR #3731: URL: https://github.com/apache/texera/pull/3731#issuecomment-3290043333
> I think changes to `core/gui/src/app/common/service/user/auth.service.ts` are missing, in `registerAutoRefreshToken` we use token renewal as activeness of user so `TOKEN_REFRESH_INTERVAL_IN_MIN` should use `active-time-in-minutes` as well Because `active-time-in-minutes` replaced the `expiryTimeInMinutes` environment variable here, `expiryTimeInMinutes` was no longer being used in `gui.conf` and it's corresponding resource `ConfigResource.scala`. I believe it was added to `gui.conf` as the env variable tied to the active window ring displaying in `admin-user.component.ts`, and was also used as the expiry time for access token refreshing. As it was no longer being used by the gui, I removed it from `ConfigResource.scala`, and `gui-config.ts` and `gui-config.service.mock.ts`. `expiration-in-minutes` config variable in `auth.conf` (which was originally in the sending logic of `ConfigResource.scala`) is still properly setting the access token TTL in `AuthResource.scala`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@texera.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
