jaeyun0503 commented on code in PR #3731:
URL: https://github.com/apache/texera/pull/3731#discussion_r2347673842
##########
core/gui/src/app/common/service/user/auth.service.ts:
##########
@@ -170,8 +170,8 @@ export class AuthService {
private registerAutoRefreshToken() {
this.refreshTokenSubscription?.unsubscribe();
- const TOKEN_REFRESH_INTERVAL_IN_MIN =
this.config.env.expirationTimeInMinutes - 1;
- // Token Refresh Interval set to Token Expiration Time - 1
+ const TOKEN_REFRESH_INTERVAL_IN_MIN = this.config.env.activeTimeInMinutes
- 1;
Review Comment:
The `TOKEN_REFRESH_INTERVAL_IN_MIN` should be set to the token's expiration
time - 1, so here it should be set to the original `expirationTimeInMinutes`.
##########
core/config/src/main/resources/auth.conf:
##########
@@ -19,7 +19,7 @@
# Configuration for JWT Authentication. Currently it is used by the
FileService to parse the given JWT Token
auth {
jwt {
- expiration-in-minutes = 15
+ expiration-in-minutes = 7200
Review Comment:
Since we want to change the default setting to 2 days, it should be 2880
minutes
##########
core/config/src/main/resources/gui.conf:
##########
@@ -100,5 +100,9 @@ gui {
# whether to send email notification when workflow execution is
completed/failed/paused/killed
workflow-email-notification-enabled = false
workflow-email-notification-enabled =
${?GUI_WORKFLOW_WORKSPACE_WORKFLOW_EMAIL_NOTIFICATION_ENABLED}
+
+ # amount of time to be elapsed in minutes before user is detected as
inactive
+ active-time-in-minutes = 15
Review Comment:
This variable needs to be moved to`auth.conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
