aglinxinyuan commented on code in PR #3735:
URL: https://github.com/apache/texera/pull/3735#discussion_r2347941250
##########
core/config/src/main/resources/default.conf:
##########
@@ -55,6 +55,9 @@ dataset {
# the file size limit for dataset upload
single_file_upload_max_size_mb = 20
+ # the maximum number of files uploading in parallel
Review Comment:
You don't need comment for this. The variable name and the comment is pretty
much the same.
##########
core/gui/src/app/dashboard/component/admin/settings/admin-settings.component.ts:
##########
@@ -191,7 +196,7 @@ export class AdminSettingsComponent implements OnInit {
}
saveDatasetSettings(): void {
- if (this.maxFileSizeMB < 1 || this.maxConcurrentChunks < 1 ||
this.chunkSizeMB < 1) {
+ if (this.maxFileSizeMB < 1 || this.maxConcurrentFiles < 1 ||
this.maxConcurrentChunks < 1 || this.chunkSizeMB < 1) {
Review Comment:
Do you really need this check here? Isn't nzInput already checked the range?
##########
core/config/src/main/resources/default.conf:
##########
@@ -55,6 +55,9 @@ dataset {
# the file size limit for dataset upload
single_file_upload_max_size_mb = 20
+ # the maximum number of files uploading in parallel
Review Comment:
You don't need comment for this. The variable name and the comment is pretty
much the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
