xuang7 commented on code in PR #3735:
URL: https://github.com/apache/texera/pull/3735#discussion_r2354127768
##########
core/gui/src/app/dashboard/component/admin/settings/admin-settings.component.ts:
##########
@@ -191,7 +196,7 @@ export class AdminSettingsComponent implements OnInit {
}
saveDatasetSettings(): void {
- if (this.maxFileSizeMB < 1 || this.maxConcurrentChunks < 1 ||
this.chunkSizeMB < 1) {
+ if (this.maxFileSizeMB < 1 || this.maxConcurrentFiles < 1 ||
this.maxConcurrentChunks < 1 || this.chunkSizeMB < 1) {
Review Comment:
Had a discussion. This adds empty input validation since nzInput does not
provide it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@texera.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
