bobbai00 commented on PR #3755: URL: https://github.com/apache/texera/pull/3755#issuecomment-3322570211
> Why don't we introduce another endpoint? What's the reason for `when installing texera in single-node mode, the multipart upload is unable to reach to the host network.` It's not a good practice that when A does not work with B, we introduce C. The codebase will become extremely large and unmanageable. I agree with the principle. In single node case, all containers are running in its own internal network and they cannot reach to host machine via `localhost` request. Therefore, when multipart uploads the example dataset, the service failed to do `PUT http://localhost:8080/presigned-url`. Since current upload API forces the usage of multipart upload, I add a new parameter to toggle it. The reason why I didn't make it a separate endpoint is because at high level, either way (multipart or not) is logically doing file uploading. Therefore they should be handled by the same endpoint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
