AnzhiZhang commented on code in PR #3715:
URL: https://github.com/apache/texera/pull/3715#discussion_r2400199787
##########
core/config/src/main/scala/edu/uci/ics/amber/config/StorageConfig.scala:
##########
@@ -65,15 +65,15 @@ object StorageConfig {
conf.getInt("storage.iceberg.table.commit.retry.max-wait-ms")
// LakeFS specifics
- val lakefsEndpoint: String = conf.getString("storage.lakefs.endpoint")
+ var lakefsEndpoint: String = conf.getString("storage.lakefs.endpoint")
Review Comment:
Setting these environment variables in the test code is too late for the
`StorageConfig` to read. I tried `lazy val` as well, and it also does not work.
Do you have any other suggestions?
```scala
System.setProperty("STORAGE_S3_ENDPOINT", minioEndpoint)
System.setProperty("STORAGE_LAKEFS_ENDPOINT", s"$lakefsBaseUrl/api/v1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
