aglinxinyuan commented on PR #3890: URL: https://github.com/apache/texera/pull/3890#issuecomment-3404232394
> Thanks. I view it the other way: the main purpose is to introduce the two helper scripts. They are critical building blocks for other scripts. And fix-format.sh is just a demo of how to use the other two util scripts. fix-format.sh is just a syntax sugar of all linter commands consolidated into one handy script. > […](#) > On Tue, Oct 14, 2025 at 6:47 PM Xinyuan Lin ***@***.***> wrote: ***@***.**** approved this pull request. LGTM! So I think the main part of this PR is to add fix-format.sh, and the other two scripts are just helpers for it, but they can also be reused by other scripts. — Reply to this email directly, view it on GitHub <[#3890 (review)](https://github.com/apache/texera/pull/3890#pullrequestreview-3338084858)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEGPVNIGE2ZGUEYZD4GSTRL3XWRTRAVCNFSM6AAAAACJALJT2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMZYGA4DIOBVHA> . You are receiving this because you were assigned.Message ID: ***@***.***> Ok. Can you explain that in the PR description? Having bullet points of 1.2.3 gave me the impression that they are at the same level and they are all the same type of helper script, but in fact, utils and fix-format are quite different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
