GitHub user gracecluvohio added a comment to the discussion: Manual testing expectations for PRs
For testing across environments, I'm not sure if it is necessary to target every single environment. We have limited time and lots of work, so I think we should only target the ones that are relevant. For instance, for frontend changes, testing across common browser; for backend, testing on similar environments to our cloud-based service/releases. Perhaps we can invest some time in creating dev containers like some other communities have done, to streamline setup for development and unify testing environments. I think the burden of testing should fall on the PR author, rather than the reviewer. They should be responsible for testing on the necessary environments and cases and documenting it appropriately. Reviewers should not have to thoroughly test the code but should rather mostly check for general code quality. If they wish to, they can also manually test the PR, but I think that requiring manual checking could discourage reviewers from reviewing PRs and also block them from doing their own dev work. Furthermore, the author is the most familiar with their own PR, so they would have the most knowledge of what to test. The fourth issue particularly resonates with me. #5961 definitely helps with dev work a lot, and I'd love to see more work to streamline development even more. Streamlining development would help make the feedback loop between testing and development a lot faster. Having better documentation for Docker and Kubernetes setup and keeping it updated would also help streamline the development process for everybody. GitHub link: https://github.com/apache/texera/discussions/6028#discussioncomment-17492826 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
