GitHub user yangzhang75 created a discussion: Proposal: Form View — the result of the step you select comes first, and the result picker moves up with a lock
## Summary On the Form View, when you select a step, that step's result card moves to the top of the Results and gets a blue ring, the same blue the canvas uses for the selected step. You can select a step by clicking it on the embedded preview, or by clicking its name in the "Results shown here" card. When you deselect it, the cards go back to their order. The "Results shown here" card also moves up, to sit between the preview and the Results, and gets a lock. Locked, clicking a name shows you that result. Unlocked, clicking a name changes which results are shown, as today. Continues the Form View (#7807, #8011). ## Demo https://github.com/user-attachments/assets/ab83c1eb-1597-48bd-be02-667a47d72365 ## Today After a run, the Form View shows one card per chosen result under the collapsed workflow preview. By default these are the final steps. If the author picked results in Edit mode, they are exactly those. (A step can have a card only if the engine kept its result, which it does for a final step and for a step whose result view is turned on.) Below the cards sits the "Results shown here" card, with one button per step. Clicking a button turns that step's result on or off: in Edit mode this changes the default everyone sees, otherwise only your own page. With more than one card, two things are missing. 1. Nothing connects a card to the step that produced it. Clicking a step on the preview opens its settings, and the Results do not react. To see what one step produced, you scroll through the other cards and find it by its title. Two steps with the same name give two cards with the same title. 2. Choosing a result and looking at it are a page apart. The "Results shown here" card is at the bottom, after all the cards, and its buttons change which results are shown. There is no way to say "show me this one now" without changing the list. ## Proposal ### 1. The selected step's result comes first Click a step on the preview (this already opens the step's panel). Its result card moves to the top of the Results and gets a ring in the same blue the canvas uses to outline the selected step. The step's button in "Results shown here" gets the same ring. The other cards keep their order. Deselect the step (click empty canvas, close the panel, or select several steps) and the cards go back and the ring goes away. Nothing is saved. This only changes what you see on your page, like the zoom buttons on a result. The author's list and its order stay as they are, and other people see nothing. If the selected step has no card (its result is not shown, or it has no result yet), the order does not change; the card moves up as soon as the step has one. So you can select a step before the run, and its result is at the top when the run finishes. ### 2. "Results shown here" moves up and gets a lock The card moves up to sit between the preview and the Results, since all three are about the same steps. The card itself is what it is today: one button per step that can have a result, highlighted when that result is shown. It gets a small lock in its corner. Locked (the default): clicking a step's button selects that step on the preview, exactly as if you had clicked the step. The step gets its ring on the canvas, its panel opens, and its card moves to the top with the ring. Clicking the button again deselects the step. A button whose result is not shown is disabled, since there is no card to show. If the preview was collapsed, it opens, so you can see which step was selected. This is also how two steps with the same name are told apart: the one that lights up on the canvas is the one you clicked. Unlocked (the card turns light blue): clicking a button turns that result on or off, exactly as today. In Edit mode that changes the default everyone sees, otherwise only your own page. Edit mode opens the card unlocked, since changing the form is what Edit mode is for, and Done locks it again. ## Open questions Should the author be able to order the cards? Today the order comes from the workflow: the final steps in the order they appear in it, and a result the author turns on later goes to the end. Dragging to reorder in the unlocked card would let the author set the order everyone sees. The selected step's card would still move to the top of it. Thoughts on the approach itself are welcome too. GitHub link: https://github.com/apache/texera/discussions/9033 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
