[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929390#action_12929390
]
Christian Lavoie commented on THRIFT-916:
-----------------------------------------
Btw, if you're curious, the warnings I have left in thriftl.cc, are:
{noformat}
/bin/sh ../../ylwrap `test -f 'src/thriftl.ll' || echo
'./'`src/thriftl.ll lex.yy.c thriftl.cc -- flex
g++ -DHAVE_CONFIG_H -I. -I../.. -Wall -I./src -g -O2 -MT thrift-thriftl.o
-MD -MP -MF .deps/thrift-thriftl.Tpo -c -o thrift-thriftl.o `test -f
'thriftl.cc' || echo './'`thriftl.cc
thriftl.cc: In function 'int yylex()':
thriftl.cc:1652: warning: comparison between signed and unsigned integer
expressions
thriftl.cc: At global scope:
thriftl.cc:3491: warning: 'int yy_flex_strlen(const char*)' defined but not used
{noformat}
With flex and g++:
{noformat}
$ flex --version ; g++ --version
flex 2.5.35
i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
{noformat}
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: make-k.log, THRIFT-916_Wall_pedantic__noerrors.patch,
> v1-fix-format-strings.patch, v1-fix-java-style-and-warnings.patch,
> v1-fix-more-warnings.patch, v1-fix-random-silly-warnings.patch,
> v2-fix-all-warnings.patch, v3-fix-all-warnings.patch,
> v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
