[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930013#action_12930013
]
Roger Meier commented on THRIFT-916:
------------------------------------
fully agree Christian! Sorry, probably a misunderstanding from my side....
I refereed to the [^v1-enable-wall-werror.patch] which contains {{-Wall
-Werror}} and I thought it sould be {{-Wall -Wextra}}
However, just add {{-Wall}} to that patch makes absolutely sense and could be
committed.
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: DebianLenny_error.log, make-k.log,
> THRIFT-916_Wall_pedantic__noerrors.patch, v1-enable-wall-werror.patch,
> v1-fix-format-strings.patch, v1-fix-java-style-and-warnings.patch,
> v1-fix-more-warnings.patch, v1-fix-random-silly-warnings.patch,
> v2-fix-all-warnings.patch, v3-fix-all-warnings.patch,
> v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
