[
https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009734#comment-13009734
]
David Reiss commented on THRIFT-1106:
-------------------------------------
Indentation looks off. Otherwise, looks fine to me.
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have
> virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Priority: Minor
> Fix For: 0.6
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual
> functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
