Dear comitters Yesterday, I activated these comments on our Continous Integration Server. Is it a good thing? Please tell me if you think this is not a feature;-)
- roger -----Ursprüngliche Nachricht----- Von: Hudson (JIRA) [mailto:[email protected]] Gesendet: Mittwoch, 23. März 2011 19:17 An: [email protected] Betreff: [jira] [Commented] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall [ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010272#comment-13010272 ] Hudson commented on THRIFT-1106: -------------------------------- Integrated in Thrift #97 (See [https://hudson.apache.org/hudson/job/Thrift/97/]) THRIFT-1106. cpp: C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall Patch: Fasih > C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have > virtual functions but no virtual destructor. Causes warnings on -Wall > -------------------------------------------------------------------------------------------------------------------------------------------- > > Key: THRIFT-1106 > URL: https://issues.apache.org/jira/browse/THRIFT-1106 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.6 > Reporter: Fasih > Assignee: Fasih > Priority: Minor > Fix For: 0.7 > > Attachments: create-virtual-dtor.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual > functions but no virtual destructor. > This causes warnings on -Wall -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
