[ 
https://issues.apache.org/jira/browse/THRIFT-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Bach updated THRIFT-1232:
--------------------------------

    Attachment: 0001-Improve-Exception-handling.patch

TException is now derived from JavaScripts Error.

Further the generated js exception code sets the name attribute to the name of 
the Struct. This allows javascript to display the by its real name instead of 
just Error.

DerivedException instanceof Error // => true
DerivedException instanceof TException // => true

Are now working

> JavaScript TException should be a constructor function
> ------------------------------------------------------
>
>                 Key: THRIFT-1232
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1232
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>            Reporter: Pascal Bach
>            Priority: Minor
>              Labels: exception-handling, js
>         Attachments: 0001-Improve-Exception-handling.patch
>
>
> The JavaScript TException is declared as an object with a prototype property 
> assigned to it.
> It should be declared as a constructor function with a prototype. Otherwise 
> exceptions derived from TException using Thrift.inherits are not instances of 
> TException.
> Example:
> function DerivedException() {};
> Thrift.inherits(DerivedException, Thrift.TException);
> var ex = new DerivedException();
> ex instanceof Thrift.TException // => Error as TException is not a function

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to