[
https://issues.apache.org/jira/browse/THRIFT-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061938#comment-13061938
]
Hudson commented on THRIFT-1232:
--------------------------------
Integrated in Thrift #186 (See [https://builds.apache.org/job/Thrift/186/])
THRIFT-1232 JavaScript TException should be a constructor function
Patch: Pascal Bach
file: 1232-Improve-Exception-handling-and-make-error-hierarchy.patch
roger : http://svn.apache.org/viewvc/?view=rev&rev=1144292
Files :
* /thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc
* /thrift/trunk/lib/js/thrift.js
> JavaScript TException should be a constructor function
> ------------------------------------------------------
>
> Key: THRIFT-1232
> URL: https://issues.apache.org/jira/browse/THRIFT-1232
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
> Reporter: Pascal Bach
> Assignee: Pascal Bach
> Priority: Minor
> Labels: exception-handling, js
> Attachments: 0001-Improve-Exception-handling.patch,
> 1232-Improve-Exception-handling-and-make-error-hierarchy.patch
>
>
> The JavaScript TException is declared as an object with a prototype property
> assigned to it.
> It should be declared as a constructor function with a prototype. Otherwise
> exceptions derived from TException using Thrift.inherits are not instances of
> TException.
> Example:
> function DerivedException() {};
> Thrift.inherits(DerivedException, Thrift.TException);
> var ex = new DerivedException();
> ex instanceof Thrift.TException // => Error as TException is not a function
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
