[ 
https://issues.apache.org/jira/browse/THRIFT-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654812#comment-13654812
 ] 

Rodrigo Setti commented on THRIFT-1965:
---------------------------------------

Thanks for the testcases.

Assuming unique identifiers was the bug. I'm preppeding an unique string (e.g. 
struct_ PlaceOrder, function_ PlaceOrder) to node names to avoid this.

Let's change the preferred file extension to ".gv", also, I think we should 
change the command line generator name from "dot" to "graphviz" or "gv" (i.e. 
--gen graphviz). sounds right?

                
> Adds dot (graph language) generator
> -----------------------------------
>
>                 Key: THRIFT-1965
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1965
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Rodrigo Setti
>            Priority: Minor
>              Labels: generate
>         Attachments: testcase.zip, thrift-latest-gen-dot.patch
>
>
> Adds DOT - the graph language - generator.
> {noformat}
>   thrift --gen dot
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to