[ 
https://issues.apache.org/jira/browse/THRIFT-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier resolved THRIFT-1982.
---------------------------------

    Resolution: Fixed
      Assignee: Roger Meier

Thanks Konrad!

;-r

Hmm, I think TOutput needs refactoring anyway ...
                
> vsnprintf on Windows have different semantics
> ---------------------------------------------
>
>                 Key: THRIFT-1982
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1982
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>            Reporter: Konrad Grochowski
>            Assignee: Roger Meier
>         Attachments: vsnprint_VisualFix.patch
>
>
> vsnprintf on Windows (visual) return -1 on failure instead of amount of bytes 
> needed.
> so line like this:
> int need = vsnprintf(stack_buf, STACK_BUF_SIZE, message, ap);
> won't work.
> Solution: ugly conditional compilation which will use microsoft specific 
> functions... See patch for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to