[
https://issues.apache.org/jira/browse/THRIFT-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675207#comment-13675207
]
Jens Geyer edited comment on THRIFT-1964 at 6/4/13 8:35 PM:
------------------------------------------------------------
Not quite, unfortunately, as none of the patches handles unset optionals
correctly. I would expect at least the serial-cases (3) and (4) working
properly for all environments including WCF. I think we indeed need to
serialize the isset flags plus some [Custom
Serialization|http://msdn.microsoft.com/en-us/library/86d80276(v=vs.85).aspx]
magic.
was (Author: jensg):
Not quite, unfortunately, as none of the patches threats unset optionals
correctly. I would expect at least the serial-cases (3) and (4) working
properly for all environments including WCF. I think we indeed need to
serialize the isset flags plus some [Custom
Serialization|http://msdn.microsoft.com/en-us/library/86d80276(v=vs.85).aspx]
magic.
> 'Isset' will cause xmlserializer crashed.
> -----------------------------------------
>
> Key: THRIFT-1964
> URL: https://issues.apache.org/jira/browse/THRIFT-1964
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
> Affects Versions: 0.9
> Environment: .net framework 3.5
> Reporter: xq.gzh
> Labels: Isset
> Attachments: 1964-v2.patch, a.thrift, fix_isset_problem_test.zip,
> fix_Isset_xmlserializer.patch, modified-testcase.zip, ReproduceTheIssue.zip,
> THRIFT-1964_Isset_causes_xmlserializer_exeption.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> same class name 'Isset' in user defined class will cause xmlserializer
> crashed.
> below is the sample thrift:
> struct A {
> 1: string x;
> }
> struct B {
> 1: string y;
> }
> struct C {
> 1:A a
> 2:B b
> }
> generate code and try xmlserialize instance of class C. it crashed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
