[
https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695816#comment-13695816
]
Roger Meier commented on THRIFT-2021:
-------------------------------------
Hmm... I think we should keep "prevent stack overflow for v. large strings"
> Improve large binary protocol string performance
> ------------------------------------------------
>
> Key: THRIFT-2021
> URL: https://issues.apache.org/jira/browse/THRIFT-2021
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9
> Reporter: Ben Craig
> Fix For: 1.0
>
> Attachments: fast_binary_strings.patch
>
>
> Currently, TBinaryProtocol reads into a temporary buffer, then copies the
> results into the resulting std::string. For large strings (like a megabyte),
> the copy can be a performance issue.
> The attached patch reads directly into the std::string instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
