[
https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790785#comment-13790785
]
Jens Geyer commented on THRIFT-2021:
------------------------------------
+1
Applies after fixing EOL style (win=>*nix), looks good to me.
> Improve large binary protocol string performance
> ------------------------------------------------
>
> Key: THRIFT-2021
> URL: https://issues.apache.org/jira/browse/THRIFT-2021
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9
> Reporter: Ben Craig
> Assignee: Ben Craig
> Fix For: 1.0
>
> Attachments: fast_binary_strings.patch
>
>
> Currently, TBinaryProtocol reads into a temporary buffer, then copies the
> results into the resulting std::string. For large strings (like a megabyte),
> the copy can be a performance issue.
> The attached patch reads directly into the std::string instead.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
