[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870719#comment-13870719
]
Pierre Lamot commented on THRIFT-2205:
--------------------------------------
+1, most languages seems to have their tests with their library. the main test
directory seems to be rather to test the compiler.
While we're at it, I think we need to refactor a little bit the tests to make
them take in parameter the protocol and the transport to use. Currently we have
a bunch of "main" program for each possibility, and we only test (in the
makefile.am) two of them.
we can do something like:
$> server.js tframedtransport tbinaryprotocol
or
$> multiplexed_server.js transport=tbufferedtransport protocol=tjsonprotocol
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Fix For: 0.9.2
>
> Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch,
> 0002-node-Bin-Frame-client-server-test-update.patch,
> 0003-node-throwed-error-should-be-instanciated.patch,
> 0004-node-fix-TJSONProtocol-parser.patch,
> 0005-node-tests-for-json-frame-and-bin-buf.patch,
> 0006-node-fix-multiplexed-processor-for-buffered-transpor.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
