[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869990#comment-13869990
]
Henrique Mendonça commented on THRIFT-2205:
-------------------------------------------
Thanks for the awesome works guys, and thanks Jens for committing it.
After so long test/test.sh can finally run again with the nodejs cross language
tests! https://travis-ci.org/apache/thrift/builds/16838109
Please feel free to close the other tickets if they were fixed by this, but
otherwise I'll check them by the end of the month. We'll also need to check the
examples folder, I think some of them won't be 100% correct any more.
@Pierre: Which kind of issue do you have with the
MultiplexedServer/FramedTransport/BinaryProtocol? Can you maybe open another
ticket for that?
@Randy: About the moving from test/nodejs to lib/nodejs/test, I think we should
move, for the reasons I've mentioned on the other ticket, unless someone else
is against it. ? What do you think? Votes?
Cheers,
Henrique
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Fix For: 0.9.2
>
> Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch,
> 0002-node-Bin-Frame-client-server-test-update.patch,
> 0003-node-throwed-error-should-be-instanciated.patch,
> 0004-node-fix-TJSONProtocol-parser.patch,
> 0005-node-tests-for-json-frame-and-bin-buf.patch,
> 0006-node-fix-multiplexed-processor-for-buffered-transpor.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
