[
https://issues.apache.org/jira/browse/THRIFT-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874804#comment-13874804
]
Jake Farrell commented on THRIFT-2184:
--------------------------------------
Thanks for the patch [~nhed]. I think that making bundler a req for the ruby
lib via make is a good idea, below is a modification to the patch you attached
which will remove the dep on rake in the Makefile and require bundler. thoughts?
{code}
diff --git a/configure.ac b/configure.ac
index 593b66c..7d9a82e 100755
--- a/configure.ac
+++ b/configure.ac
@@ -232,9 +232,8 @@ AX_THRIFT_LIB(ruby, [Ruby], yes)
have_ruby=no
if test "$with_ruby" = "yes"; then
AC_PATH_PROG([RUBY], [ruby])
- AC_PATH_PROG([RAKE], [rake])
AC_PATH_PROG([BUNDLER], [bundle])
- if test "x$RUBY" != "x" -a "x$RAKE" != "x"; then
+ if test "x$RUBY" != "x" -a "x$BUNDLER" != "x"; then
have_ruby="yes"
fi
fi
diff --git a/lib/rb/Makefile.am b/lib/rb/Makefile.am
index 091c67f..300f676 100755
--- a/lib/rb/Makefile.am
+++ b/lib/rb/Makefile.am
@@ -29,21 +29,21 @@ EXTRA_DIST = \
DESTDIR ?= /
-all-local:
if HAVE_BUNDLER
+
+all-local:
$(BUNDLER) install
$(BUNDLER) exec rake
-endif
install-exec-hook:
- $(RAKE) install
+ $(BUNDLER) exec rake install
clean-local:
- $(RAKE) clean
+ $(BUNDLER) exec rake clean
check-local: all
-if HAVE_BUNDLER
$(BUNDLER) install
$(BUNDLER) exec rake
+
endif
{code}
> undefined method rspec_verify for Thrift::MemoryBufferTransport
> ---------------------------------------------------------------
>
> Key: THRIFT-2184
> URL: https://issues.apache.org/jira/browse/THRIFT-2184
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.9.1
> Reporter: Paul Brannan
> Attachments: THRIFT-2184.patch
>
>
> When running 'make install', I get the following errors that do not occur
> when just running 'make':
> {noformat}
> 1) BinaryProtocolAccelerated it should behave like a binary protocol should
> write a byte
> Failure/Error: @trans.rspec_verify
> NoMethodError:
> undefined method `rspec_verify' for
> #<Thrift::MemoryBufferTransport:0x000000034e86c8>
> Shared Example Group: "a binary protocol" called from
> ./spec/binary_protocol_accelerated_spec.rb:28
> # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in <top
> (required)>'
> 2) BinaryProtocol it should behave like a binary protocol should write a
> byte
> Failure/Error: @trans.rspec_verify
> NoMethodError:
> undefined method `rspec_verify' for
> #<Thrift::MemoryBufferTransport:0x000000034509e0>
> Shared Example Group: "a binary protocol" called from
> ./spec/binary_protocol_spec.rb:25
> # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in <top
> (required)>'
> {noformat}
> I commented out the call to #rspec_verify, but I do not know what the correct
> fix is.
> I also get numerous (related) warnings about mock being deprecated:
> {noformat}
> DEPRECATION: mock is deprecated. Use double instead. Called from
> /home/pbrannan/git/thrift/lib/rb/spec/unix_socket_spec.rb:93:in `block (3
> levels) in <top (required)>'.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
