[
https://issues.apache.org/jira/browse/THRIFT-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Lamot updated THRIFT-2327:
---------------------------------
Attachment: 0001-THRIFT-2327-nodejs-nodejs-test-suite-should-be-bundl.patch
Hi
this patch :
- move node test suite from test/nodejs to lib/nodejs/test
- add command line options to client/server tests to setup protocol and
transport
- add a testAll.sh in lib/nodejs/test to run all the tests (this script might
be called by npm test)
However, tests are no longer ran by the global "make check", what disturbed me
was that node library require to download dependencies to run (node-int64) and
to run the tests (I added a dependency on commander.js). I didn't want to cause
the global test suite to fail if no Internet connection is available. Any
thought?
Best regards,
Pierre
> nodejs: nodejs test suite should be bundled with the library
> ------------------------------------------------------------
>
> Key: THRIFT-2327
> URL: https://issues.apache.org/jira/browse/THRIFT-2327
> Project: Thrift
> Issue Type: Test
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Reporter: Pierre Lamot
> Priority: Minor
> Attachments:
> 0001-THRIFT-2327-nodejs-nodejs-test-suite-should-be-bundl.patch
>
>
> as discussed in THRIFT-2205, this issue is about moving node test suite to
> nodejs library folder and unifying tests (taking configuration from command
> line and testing each kind of protocol/transport configurations)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
