[ 
https://issues.apache.org/jira/browse/THRIFT-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Lamot updated THRIFT-2327:
---------------------------------

    Attachment: 0001-THRIFT-2327-nodejs-nodejs-test-suite-should-be-bundl.patch

Hi,

sorry for the lag,

So I updated my patch: 
  - test are ran with make check
  - node executable is check during the configure
  - tests uses the same arguments as test/test.sh tests (binary vs 
TBinaryProtocol)
  - tests are run agains C++ implementation in test/test.sh


> nodejs: nodejs test suite should be bundled with the library
> ------------------------------------------------------------
>
>                 Key: THRIFT-2327
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2327
>             Project: Thrift
>          Issue Type: Test
>          Components: Node.js - Library
>    Affects Versions: 0.9.2
>            Reporter: Pierre Lamot
>            Priority: Minor
>         Attachments: 
> 0001-THRIFT-2327-nodejs-nodejs-test-suite-should-be-bundl.patch
>
>
> as discussed in  THRIFT-2205, this issue is about moving node test suite to 
> nodejs library folder and unifying tests (taking configuration from command 
> line and testing each kind of protocol/transport configurations)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to