Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/142#issuecomment-46338660
The failing TFDTransport test is not about avoiding double-close but
ensuring that the destructor throws.
The problem is that C++11 defaults destructors to noexcept(true), which the
original test code doesn't suppose and breaks the test.
Here we can either
a. attribute TTransport destructor with noexept(false),
b. disable the test if C++11 is enabled or
c. change the TFDTransport excpetion inside destructor to perror (as
suuyaoo suggests).
Last one seems reasonable to me although it breaks backward compatibility
because
a. the other two make thrift C++ lib tedious to use and
b. no other TTransport subclasses inside lib/cpp doesn't throw from inside
its destructor AFAIK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
