Github user ben-craig commented on the pull request:
https://github.com/apache/thrift/pull/142#issuecomment-46441037
Exceptions shouldn't leave close() or a destructor. I agree about that.
I am still concerned about this sequence of events though:
int rv = ::THRIFT_CLOSE(fd_);
...
if (rv < 0 && !std::uncaught_exception())
{
GlobalOutput.perror("TFDTransport::close() ", errno_copy);
}
Why are we ever getting into the perror case? Why is rv < 0? The main
reason for ::THRIFT_CLOSE to fail is if fd_ is invalid. Closing invalid file
descriptors is a bug.
Are you hitting the exception / perror on a regular basis? If so, that
seems like a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
