[ 
https://issues.apache.org/jira/browse/THRIFT-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047594#comment-14047594
 ] 

Grzegorz Leszczyński commented on THRIFT-2521:
----------------------------------------------

I get back to debugging this other crash, which I mentioned, and I found when 
it happens. When TNonblockingServer is used with ThreadManager, 
ThreadManager::stop() must be called before destroying TNonblockingServer 
instance, otherwise crashes can happen. I think this call to stop() should be 
added in TNonblockingServer destructor, but I'm not sure if this manager can be 
shared between many servers, so I'm not sending patch. I just call stop() 
manually before destroying TNonblockingServer instance and suggest you add this 
call in destructor.


> Fixed synchronisation in ThreadManager.cpp
> ------------------------------------------
>
>                 Key: THRIFT-2521
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2521
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.2, 1.0
>            Reporter: Grzegorz Leszczyński
>              Labels: patch
>             Fix For: 0.9.2, 1.0
>
>         Attachments: thrift-2521-ThreadManager.patch
>
>
> Server can crash, when stop is called. Fixes also other minor synchronisation 
> problems.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to