[
https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071518#comment-14071518
]
Stig Bakken commented on THRIFT-2632:
-------------------------------------
Gotcha! Fixed, and added a test script for good measure.
I also disabled the write validation for unions, since the "opt_in_req_out"
rule works badly for unions. I didn't try to be smart about validating PHP
unions though, since that is a completely different can of worms.
> PHP: add "validate" option to generate read/write validation code
> -----------------------------------------------------------------
>
> Key: THRIFT-2632
> URL: https://issues.apache.org/jira/browse/THRIFT-2632
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler
> Reporter: Stig Bakken
> Assignee: Jens Geyer
> Priority: Minor
>
> Currently, generated PHP code will happily read and write messages with
> missing required fields. This patch adds a "validate" option for PHP to
> generate validator methods and call them after reading and before writing
> objects
> If a required field is missing, a TProtocolException is thrown both for read
> and write.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
