[
https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072272#comment-14072272
]
Jens Geyer commented on THRIFT-2632:
------------------------------------
Hi, thanks, adding a test is a good idea.!
May I still ask one thing? The policy for tests is, that the {{/test}} dir
holds the cross-laguage tests (the one which utilize {{ThriftTest.thrift}}) and
other commonly used tests, while the language specific tests should reside
within {{/lib/php/test}}. Could you move the validation test to that place?
> PHP: add "validate" option to generate read/write validation code
> -----------------------------------------------------------------
>
> Key: THRIFT-2632
> URL: https://issues.apache.org/jira/browse/THRIFT-2632
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler
> Reporter: Stig Bakken
> Assignee: Jens Geyer
> Priority: Minor
>
> Currently, generated PHP code will happily read and write messages with
> missing required fields. This patch adds a "validate" option for PHP to
> generate validator methods and call them after reading and before writing
> objects
> If a required field is missing, a TProtocolException is thrown both for read
> and write.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
