[
https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118955#comment-14118955
]
ASF GitHub Bot commented on THRIFT-2689:
----------------------------------------
GitHub user talentdeficit opened a pull request:
https://github.com/apache/thrift/pull/204
THRIFT-2689: struct names that differ only in capitalization of first
character generate broken erlang code
alter generation so that accurate names are retained in generated code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/talentdeficit/thrift thrift-2689
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit 9c3dfc04ab97eef623b3b1820d61f7823ff5070a
Author: alisdair sullivan <[email protected]>
Date: 2014-09-02T23:28:24Z
THRIFT-2689: struct names that differ only in capitalization of first
character generate broken erlang code
alter generation so that accurate names are retained in generated code
----
> struct names that differ only in capitalization of first character generate
> broken erlang code
> ----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2689
> URL: https://issues.apache.org/jira/browse/THRIFT-2689
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Compiler, Erlang - Library
> Reporter: alisdair sullivan
> Priority: Minor
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that
> it starts with a lowercase letter. instead, it should leave names intact and
> use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
