[
https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161577#comment-14161577
]
ASF GitHub Bot commented on THRIFT-2689:
----------------------------------------
GitHub user talentdeficit opened a pull request:
https://github.com/apache/thrift/pull/239
THRIFT-2689 (fix)
client: haskell
patch: alisdair sullivan
remove struct from NameConflictTest.thrift that causes problems for
certain backends
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/talentdeficit/thrift thrift-2689-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #239
----
commit d6e4f47eb0fdbc5efe60906a106d6f61630d7a87
Author: alisdair sullivan <[email protected]>
Date: 2014-10-07T07:15:27Z
THRIFT-2689 (fix)
client: haskell
patch: alisdair sullivan
remove struct from NameConflictTest.thrift that causes problems for
certain backends
----
> struct names that differ only in capitalization of first character generate
> broken erlang code
> ----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2689
> URL: https://issues.apache.org/jira/browse/THRIFT-2689
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Compiler, Erlang - Library
> Reporter: alisdair sullivan
> Assignee: alisdair sullivan
> Priority: Minor
> Fix For: 0.9.2
>
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that
> it starts with a lowercase letter. instead, it should leave names intact and
> use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
