GitHub user m50d opened a pull request:

    https://github.com/apache/thrift/pull/253

    Pull TAsyncProcessor interface out of TBaseAsyncProcessor

    As briefly mentioned on IRC (I'm lmm). This makes it possible to use e.g. 
TNonblockingServer with a custom async processor that doesn't extend 
TBaseAsyncProcessor.
    
    (Use case: I have an implementation in scrooge that generates such async 
processors, for use in scala).
    
    Async processors still need to "implement" TProcessor so that they can be 
configured as a processor (the implementation can be simply `return false` as 
it is in `TBaseAsyncProcessor`); this is somewhat awkward but a change to make 
that unnecessary would be much more intrusive.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/m50d/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 9cde8b7721f5d326602b36bb9978bdd3d458da25
Author: Michael Donaghy <[email protected]>
Date:   2014-11-07T10:19:26Z

    Attempt to add TAsyncProcessor

commit 3241078784defe1280ac410b9bb3def2c787084f
Author: Michael Donaghy <[email protected]>
Date:   2014-11-07T14:10:26Z

    comment the requirement

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to