[ 
https://issues.apache.org/jira/browse/THRIFT-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202208#comment-14202208
 ] 

ASF GitHub Bot commented on THRIFT-2804:
----------------------------------------

Github user m50d commented on the pull request:

    https://github.com/apache/thrift/pull/253#issuecomment-62168798
  
    Jira issue created: https://issues.apache.org/jira/browse/THRIFT-2804


> Pull an interface out of TBaseAsyncProcessor
> --------------------------------------------
>
>                 Key: THRIFT-2804
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2804
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>            Reporter: Michael Donaghy
>
> TNonblockingServer and friends are currently quite tightly coupled to 
> TBaseAsyncProcessor, using an instanceof check to determine whether to use 
> the async-processor or sync-processor code path. This makes it impossible to 
> write a "custom" async processor, as any processor which is not a 
> TBaseAsyncProcessor will use the sync code path (which behaves incorrectly 
> with async processors).
> The idea is to separate out an interface, TAsyncProcessor. Custom async 
> processors can then implement this interface and the server will take the 
> async code path when used with such a processor.
> Code at https://github.com/apache/thrift/pull/253



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to