[
https://issues.apache.org/jira/browse/THRIFT-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299979#comment-14299979
]
Randy Abernethy commented on THRIFT-2959:
-----------------------------------------
Hey Andrew,
Great patch, ran into a couple of issues.
1) My nodeunit path after npm install on Ubuntu 14.04.1 LTS is:
../node_modules/nodeunit/bin/nodeunit
2) Would be nice to have a passing test so the commit doesn't break the build
(I am going through these in the order listed from your email)
Best,
Randy
> nodejs: fix binary unit tests
> -----------------------------
>
> Key: THRIFT-2959
> URL: https://issues.apache.org/jira/browse/THRIFT-2959
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Environment: Trusty64 Vagrant Box
> Reporter: Andrew de Andrade
> Priority: Minor
> Attachments: thrift-2959-nodejs-fix-binary-unit-tests.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
