[
https://issues.apache.org/jira/browse/THRIFT-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300020#comment-14300020
]
Andrew de Andrade commented on THRIFT-2959:
-------------------------------------------
That is really odd. Run this command: {{npm config get bin-links}}
If that shows false, then run {{npm config set bin-links true}}. True is the
default value and if yours shows false, then that is very strange. I ran npm
install locally in the project folder. I'm wondering if there is something
unusual about how the makefile scripts are running `npm install`.
There is also this issue on https://github.com/npm/npm/issues/4851 but no one
has claimed that this issue affects ubuntu and that seems to be about users of
n (a node version manager), which AFAICT is not used in the thrift setup, is it?
Plus, caolan/nodeunit's package.json definitely has a "bin" prop defined:
https://github.com/caolan/nodeunit/blob/master/package.json#L84
I will spin up a new vm after lunch and try investigating why the
../node_modules/.bin folder isn't being created, since that is where the
problem appears to lie here. We could change the path to point at the one you
used, but the only downside is that you won't be able to use the binary names
in the "scripts" properties in the package.json, since all the `npm run
<script>` commands add the ../node_modules/.bin folder to the internal PATH
variable npm uses when probing for executables.
> nodejs: fix binary unit tests
> -----------------------------
>
> Key: THRIFT-2959
> URL: https://issues.apache.org/jira/browse/THRIFT-2959
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Environment: Trusty64 Vagrant Box
> Reporter: Andrew de Andrade
> Priority: Minor
> Attachments: thrift-2959-nodejs-fix-binary-unit-tests.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
