[
https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320381#comment-14320381
]
Randy Abernethy commented on THRIFT-2998:
-----------------------------------------
This is a great patch. Post THRIFT-2756 the official media type should probably
be based on the actual type of media (therefore the serialization protocol).
The IANA registered media types are:
- vnd.apache.thrift.json
- vnd.apache.thrift.binary
- vnd.apache.thrift.compact
I can commit this as a step in the right direction but ultimately the media
type should come from the protocol. Perhaps the protocols should have a Public
readonly property set to their media type that the http layer can use.
Thoughts?
-Randy
> Node.js: Missing header from http request
> -----------------------------------------
>
> Key: THRIFT-2998
> URL: https://issues.apache.org/jira/browse/THRIFT-2998
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Reporter: Traian Stanev
>
> The "Content-Type" header is not being set to "application/x-thrift" when
> making http requests in the node.js implementation. This results in error
> response (status 400) for any such connections (depending on whether the
> server checks the header). The Python implementation for example adds the
> header explicitly:
> https://github.com/tstanev/thrift/blob/master/lib/py/src/transport/THttpClient.py#L127
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
