[
https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569398#comment-14569398
]
ASF GitHub Bot commented on THRIFT-2998:
----------------------------------------
Github user RandyAbernethy commented on the pull request:
https://github.com/apache/thrift/pull/378#issuecomment-108011615
No worse than no header I suppose, however Thrift media types are now per
protocol and registered with IANA:
http://www.iana.org/assignments/media-types/media-types.xhtml#application
- vnd.apache.thrift.binary
- vnd.apache.thrift.compact
- vnd.apache.thrift.json
Would be nice if we could mount a Thrift wide effort to get these into
Thrift v1.0. If you need application/x-thrift in the mean time I suppose we
could commit it with a TODO.
Thoughts?
> Node.js: Missing header from http request
> -----------------------------------------
>
> Key: THRIFT-2998
> URL: https://issues.apache.org/jira/browse/THRIFT-2998
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Reporter: Traian Stanev
>
> The "Content-Type" header is not being set to "application/x-thrift" when
> making http requests in the node.js implementation. This results in error
> response (status 400) for any such connections (depending on whether the
> server checks the header). The Python implementation for example adds the
> header explicitly:
> https://github.com/tstanev/thrift/blob/master/lib/py/src/transport/THttpClient.py#L127
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
