[
https://issues.apache.org/jira/browse/THRIFT-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388733#comment-14388733
]
ASF GitHub Bot commented on THRIFT-2820:
----------------------------------------
GitHub user uvwxy opened a pull request:
https://github.com/apache/thrift/pull/413
[THRIFT-2820] Implement an alternative Transport for JS using the AngularJS
$http-service
I added the target --gen js:angular to generate angularjs targeted thrift
service clients. The thrift.js has been modified simliar to the --gen js:jquery
target.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uvwxy/thrift dev-uvwxy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/413.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #413
----
commit 6e3167d568911019b543697db337846058ed47c8
Author: Paul Smith <[email protected]>
Date: 2015-03-26T19:21:55Z
m: untested initial version that generates angular js targeted code
commit a06fc739938440fcce1d9cf01fc5bad29f6045bd
Author: Paul Smith <[email protected]>
Date: 2015-03-29T10:26:41Z
m: use Content-Type as described in THRIFT-2756
commit c3237d14dde47ab495b95c171180f530e08e3ea7
Author: Paul Smith <[email protected]>
Date: 2015-03-29T14:35:28Z
m: integrate angular implementation into qunit tests (still failing)
commit cc8764001774c008f9d17d9fca1e1a23336fefb7
Author: Paul Smith <[email protected]>
Date: 2015-03-29T14:43:25Z
m: cleanup (96 assertions of 104 passed, 8 failed)
commit 71ead83979882f2c238e8d6be055ed4bbaccc8ef
Author: Paul Smith <[email protected]>
Date: 2015-03-29T14:56:17Z
m: fallback to jqRequest if not initialized (make test.js async work)
commit c27875f9703e26ea2816649eca0a75a2ed6f01bd
Author: Paul Smith <[email protected]>
Date: 2015-03-29T14:58:48Z
m: cleanup (all assertions pass)
commit 61d13c5d146c9feba7a77a3a6194ca564172e58e
Author: Paul Smith <[email protected]>
Date: 2015-03-29T15:00:23Z
b: add missing ;
commit ddeb8c1214e0447c75674feecd3fc051db37c171
Author: Paul Smith <[email protected]>
Date: 2015-03-29T15:29:51Z
m: fix correct handling of exceptions
commit b37ff7b07194dec51891c9695a2761702db45eea
Author: Paul Smith <[email protected]>
Date: 2015-03-29T16:11:48Z
m: use factory instead of controller
commit 41631058afca3ebf0998a0bbdf9b0cafa6267583
Author: Paul Smith <[email protected]>
Date: 2015-03-29T20:36:47Z
m: added --gen js:angular=appvar to enable factory generation
----
> Implement an alternative Transport for JS using the AngularJS $http-service
> ---------------------------------------------------------------------------
>
> Key: THRIFT-2820
> URL: https://issues.apache.org/jira/browse/THRIFT-2820
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Environment: AngularJS, Browser
> Reporter: David Sautter
> Priority: Minor
> Labels: features
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Since the architecture of the Thrift-library for Javascript-clients allows us
> to use custom Transports, I would like to have a Transport using the
> AngularJS $http-service. This would allow us to mock a Thrift Server in Tests
> as well as intercepting and customizing Thrift requests (e.g. authentication).
> The Tansport can be included into your AngularJS App via a module so that you
> can use it to instantiate your clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
