[
https://issues.apache.org/jira/browse/THRIFT-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543482#comment-14543482
]
ASF GitHub Bot commented on THRIFT-2820:
----------------------------------------
Github user uvwxy commented on a diff in the pull request:
https://github.com/apache/thrift/pull/413#discussion_r30312844
--- Diff: lib/js/test/test-angular.html ---
@@ -0,0 +1,58 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
+<head>
+ <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+ <title>Thrift Javascript Bindings: Unit Test</title>
+
+ <script src="build/js/thrift.js" type="text/javascript"
charset="utf-8"></script>
+ <script src="gen-js/ThriftTest_types.js" type="text/javascript"
charset="utf-8"></script>
+ <script src="gen-js/ThriftTest.js" type="text/javascript"
charset="utf-8"></script>
+
+ <!-- AngularJS + Dependency-->
+ <script
src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.3/jquery.min.js";></script>
--- End diff --
The dependency is required to run the tests that do not use the angular js
service.
> Implement an alternative Transport for JS using the AngularJS $http-service
> ---------------------------------------------------------------------------
>
> Key: THRIFT-2820
> URL: https://issues.apache.org/jira/browse/THRIFT-2820
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Environment: AngularJS, Browser
> Reporter: David Sautter
> Priority: Minor
> Labels: features
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Since the architecture of the Thrift-library for Javascript-clients allows us
> to use custom Transports, I would like to have a Transport using the
> AngularJS $http-service. This would allow us to mock a Thrift Server in Tests
> as well as intercepting and customizing Thrift requests (e.g. authentication).
> The Tansport can be included into your AngularJS App via a module so that you
> can use it to instantiate your clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
