Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/476#issuecomment-98530788
  
    nice idea, but the introduction of new structs within 
test/ThriftTest.thrift breaks many other language tests, do you really need new 
structs? e.g.  BonkMap is available as MapType
    There is also a inconsistent naming: ListBonks, BonkSet, BonkMap 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to