Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-98653372
Hi Itkach,
I also had a look at your patch before and it looks valid but the problem
here is the BonkSet, which in C++ will require comparison operators, as you can
see in:
https://travis-ci.org/apache/thrift/jobs/60874797#L1480
As you said an ,alternative would be to create a separated test for that.
I also wonder if the compiler is the right place to add the __thriftCopyXXX
functions, I think they should probably belong to the library code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
