[
https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532258#comment-14532258
]
Konrad Grochowski commented on THRIFT-3130:
-------------------------------------------
after short investigation: when THRIFT_OVERLOAD_IF was added, Thrift required
boost 1.33.0, which did not have 'is convertible' in it's shared_ptr
copy-convert constructor.
{code}
template<class Y>
shared_ptr(shared_ptr<Y> const & r): px(r.px), pn(r.pn) // never throws
{
}
{code}
So this 'overload if' was required, or compiler get lost.
I've checked boost repo - proper constructor is definitely present in 1.53.0,
which is current base line for Thrift, so THRIFT_OVERLOAD_IF may die finally!
I wonder when boost introduced it... I've just checked if we're safe, didn't
want to go through all boost git log ;)
-----------------
Please add TOutput.h to proper _HEADERS directive in Makefile.am and I'll merge
it.
> Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316
> ---------------------------------------------------------------
>
> Key: THRIFT-3130
> URL: https://issues.apache.org/jira/browse/THRIFT-3130
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> In THRIFT-1316 some macros were added that have proven to be unnecessary.
> They were partially eliminated in THRIFT-3083, and this traces the removal of
> what was left. In addition, TOutput was moved to its own class, and since
> TThrift.cpp only contained TOutput code, it was renamed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
