[
https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532649#comment-14532649
]
Hudson commented on THRIFT-3130:
--------------------------------
SUCCESS: Integrated in Thrift #1536 (See
[https://builds.apache.org/job/Thrift/1536/])
THRIFT-3130 - C++ Lib: removed no longer needed macro THRIFT_OVERLOAD_IF
(hcorg: rev 24ea0bf5df0e431416fca897077af220a27b0320)
* lib/cpp/src/thrift/server/TThreadedServer.cpp
* lib/cpp/src/thrift/server/TServer.h
* lib/cpp/CMakeLists.txt
* lib/cpp/test/TServerIntegrationTest.cpp
* lib/cpp/src/thrift/Thrift.h
* lib/cpp/src/thrift/TOutput.h
* lib/cpp/src/thrift/server/TSimpleServer.cpp
* lib/cpp/src/thrift/server/TThreadPoolServer.cpp
* lib/cpp/Makefile.am
* lib/cpp/src/thrift/Thrift.cpp
* lib/cpp/src/thrift/server/TNonblockingServer.h
* lib/cpp/src/thrift/TOutput.cpp
> Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316
> ---------------------------------------------------------------
>
> Key: THRIFT-3130
> URL: https://issues.apache.org/jira/browse/THRIFT-3130
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
> Fix For: 0.9.3
>
>
> In THRIFT-1316 some macros were added that have proven to be unnecessary.
> They were partially eliminated in THRIFT-3083, and this traces the removal of
> what was left. In addition, TOutput was moved to its own class, and since
> TThrift.cpp only contained TOutput code, it was renamed.
> Boost gained this mechanism internally in a release after boost-1.33 which is
> what was required when THRIFT-1316 was added to the codebase. With the
> current minimum requirement of 1.53, it is safe to remove THRIFT_OVERLOAD_IF.
> Tests confirm this (in TServerIntegrationTest).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
