[
https://issues.apache.org/jira/browse/THRIFT-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553282#comment-14553282
]
Hudson commented on THRIFT-3150:
--------------------------------
SUCCESS: Integrated in Thrift #1559 (See
[https://builds.apache.org/job/Thrift/1559/])
THRIFT-3150 Add an option to make Read and Write methods private (jensg: rev
70219e108a01340380f65e1ece8d63620d5e22a5)
* lib/go/test/Makefile.am
* lib/go/test/DontExportRWTest.thrift
* lib/go/test/dontexportrwtest/compile_test.go
* compiler/cpp/src/generate/t_go_generator.cc
> Add an option to thrift go generator to make Read and Write methods private
> ---------------------------------------------------------------------------
>
> Key: THRIFT-3150
> URL: https://issues.apache.org/jira/browse/THRIFT-3150
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Konstantin Shaposhnikov
> Assignee: Konstantin Shaposhnikov
> Fix For: 0.9.3
>
>
> I propose to add a new option *dont_export_rw* to go generator that if set
> will make it generate private read() and wirte() methods instead of public
> ones. E.g.:
> {code}
> func (p *Statistics) read(iprot thrift.TProtocol) error {
> ...
> }
> func (p *Statistics) write(oprot thrift.TProtocol) error {
> ....
> }
> {code}
> This will allow (along with THRIFT-3149) to generate a package that doesn't
> reference any symbols from Thrift Go library in public API.
> There are two main benefits:
> - keeping API of generated packages clean (only generated types are exported)
> - allowing to generate packages that can use vendored thrift library (e.g.
> placed inside internal/ directory).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
